From c57c057008bba9333fd32f9ec7011181e98a6179 Mon Sep 17 00:00:00 2001
From: Hamza Remmal <hamza@remmal.net>
Date: Tue, 4 Feb 2025 14:36:04 +0100
Subject: [PATCH] fix: jackson was not able to deserialise
UploadFeedbackRequest
---
.../api/v1/SubmissionController.java | 2 +-
.../model/request/UploadFeedbackRequest.java | 18 ++++--------------
2 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/autograde-service/src/main/java/ch/epfl/autograde/controller/api/v1/SubmissionController.java b/autograde-service/src/main/java/ch/epfl/autograde/controller/api/v1/SubmissionController.java
index 4061ce47..ca2d8b43 100644
--- a/autograde-service/src/main/java/ch/epfl/autograde/controller/api/v1/SubmissionController.java
+++ b/autograde-service/src/main/java/ch/epfl/autograde/controller/api/v1/SubmissionController.java
@@ -152,7 +152,7 @@ public final class SubmissionController {
{
log.info("Processing request to upload the feedback for submission {}", id);
integrity.check(signature, id);
- var res = moodle.upload_feedback(id, feedback.getGrade(), feedback.getFiles());
+ var res = moodle.upload_feedback(id, feedback.grade(), feedback.files());
if (res.statusCode() != HttpStatus.OK.value()) {
// TODO: Clean the MoodleService API
throw new RuntimeException("Moodle request returned with status: " + res.statusCode() + " " + res.body());
diff --git a/autograde-service/src/main/java/ch/epfl/autograde/model/request/UploadFeedbackRequest.java b/autograde-service/src/main/java/ch/epfl/autograde/model/request/UploadFeedbackRequest.java
index 9ba9b463..0f732c21 100644
--- a/autograde-service/src/main/java/ch/epfl/autograde/model/request/UploadFeedbackRequest.java
+++ b/autograde-service/src/main/java/ch/epfl/autograde/model/request/UploadFeedbackRequest.java
@@ -1,20 +1,10 @@
package ch.epfl.autograde.model.request;
import ch.epfl.autograde.model.entity.MoodleFile;
-import com.fasterxml.jackson.annotation.JsonProperty;
-import lombok.Builder;
-import lombok.Data;
import java.util.List;
-@Data
-@Builder
-public final class UploadFeedbackRequest {
-
- @JsonProperty
- private final float grade;
-
- @JsonProperty
- private final List<MoodleFile> files;
-
-}
+public record UploadFeedbackRequest (
+ float grade,
+ List<MoodleFile> files
+) { }
--
GitLab