From a476b206d6b4fa55ce22c3d1f43219ef28168c91 Mon Sep 17 00:00:00 2001
From: Luke Simons <luke.simons@epfl.ch>
Date: Thu, 20 Feb 2025 09:34:18 +0100
Subject: [PATCH] Added comments with suggested changes

---
 matlab/TCV_IMAS/tcv_get_ids_soft_x_rays.m | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/matlab/TCV_IMAS/tcv_get_ids_soft_x_rays.m b/matlab/TCV_IMAS/tcv_get_ids_soft_x_rays.m
index dd5ea58..34cea3e 100644
--- a/matlab/TCV_IMAS/tcv_get_ids_soft_x_rays.m
+++ b/matlab/TCV_IMAS/tcv_get_ids_soft_x_rays.m
@@ -27,7 +27,7 @@ if exist('gdat_params')
 else
   [ids_soft_x_rays, ~] = tcv_ids_headpart(shot, ids_soft_x_rays_empty, ...
       'soft_x_rays','homogeneous_time',0, ...
-      'comment','RADCAM Soft X-Ray 47um Be filered optodiode AXUV@0ELGDS diodes', ...
+      'comment','RADCAM Soft X-Ray 47um Be filered optodiode AXUV20ELGDS diodes', ...
       varargin{:});
 end
 
@@ -37,6 +37,10 @@ ids_soft_x_rays_description = struct();
 sxr_geom=sxr_load_geometry();
 sxr_data=rc_load_diodes(shot,'diag_name','sxr');
 status=numel(sxr_data.data)>0;
+
+%get gdat version, FIXME: Need to write function
+%radcam_repo_version=imas_get_code_version();
+
 if status
   nchannel = sum(rc_n_chn(shot,'sxr'));
   ids_soft_x_rays.channel(1:nchannel) = ids_soft_x_rays.channel(1);
@@ -54,6 +58,9 @@ if status
         ['RADCAM Soft X-Ray (SXR) system, global index from clock-wise ' ...
         'ordering from inboard side'];
     
+    %ids_soft_x_rays_description.channel{ii}.description = ...
+    %   [sprintf('SXR Diode detector %d, %s Line of Sight %d',ii,,)];
+    
     ids_soft_x_rays.channel{ii}.detector.geometry_type= sxr_geom.channel{ii}.detector.geometry_type;
     ids_soft_x_rays.channel{ii}.detector.centre.phi= sxr_geom.channel{ii}.detector.centre.phi;
     ids_soft_x_rays.channel{ii}.detector.centre.r= sxr_geom.channel{ii}.detector.centre.r;
-- 
GitLab