Skip to content
Snippets Groups Projects

Add EC launcher & gyrotron information to ec_data output

Merged Antonia Frank requested to merge add-ec-launcher-gyrotron-information into master

Merge request reports

Pipeline passed for a443d3aa on add-ec-launcher-gyrotron-information

Test coverage 6.57% (0.08%) from 1 job
Test summary results are being parsed

Merged by Antonia FrankAntonia Frank 11 months ago (May 23, 2024 7:36am UTC)

Loading

Pipeline passed for a443d3aa on master

Test coverage 6.57% (0.08%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Antonia Frank added 1 commit

    added 1 commit

    • 3659ccf5 - Add ec_inputs structure to ec_data call, launching write_pgyro

    Compare with previous version

  • Antonia Frank added 1 commit

    added 1 commit

    • ae646ee1 - Make launcher num labels for both ec_data and ec_inputs

    Compare with previous version

  • Antonia Frank resolved all threads

    resolved all threads

  • Antonia Frank resolved all threads

    resolved all threads

  • Antonia Frank added 1 commit

    added 1 commit

    • 8d85672f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Antonia Frank added 1 commit

    added 1 commit

    • 9fd6a646 - Add check_nodes_filled call to ec_data with toray & cleanup empty outputs

    Compare with previous version

  • Antonia Frank added 1 commit

    added 1 commit

    • 22c338f3 - Change again, add try catch and flag to check if data retrieved completely

    Compare with previous version

  • Antonia Frank added 1 commit

    added 1 commit

    • 8ce72d21 - Add some checks to identify why ec_data from toray could not be read

    Compare with previous version

  • Antonia Frank
  • Antonia Frank
  • Antonia Frank requested review from @osauter

    requested review from @osauter

  • Author Developer

    @osauter can we merge this?

    Edited by Antonia Frank
  • Olivier Sauter resolved all threads

    resolved all threads

  • Antonia Frank added 8 commits

    added 8 commits

    • 6db3b452 - 1 commit from branch master
    • d8f4007a - add integrated cd and pdens to ec_data output and correct x dim for different launchers
    • c790f1eb - Add ec_inputs structure to ec_data call, launching write_pgyro
    • cdf5fe11 - Make launcher num labels for both ec_data and ec_inputs
    • 29e74f5e - Apply 1 suggestion(s) to 1 file(s)
    • 3f99932b - Add check_nodes_filled call to ec_data with toray & cleanup empty outputs
    • 33070e9a - Change again, add try catch and flag to check if data retrieved completely
    • f1ceba89 - Add some checks to identify why ec_data from toray could not be read

    Compare with previous version

  • Hi @osauter, I just rebased on master, thus again ready to merge. I saw that you resolved all threads 4 weeks ago but don't know if this means I should merge it. Should I? ;) Is it fine from your side?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading