Merge branch 'ci/adding-linters' into 'main'

Adding linters (should make components for this)

See merge request !33

.gitlab-ci.yml

@@ -2,6 +2,8 @@
 # yaml-language-server: $format.enable=false
 
 stages:
+  - linters
+  - checkout
   - environment
   - compilers
   - concretize
@@ -104,7 +106,7 @@ variables:
 # ------------------------------------------------------------------------------
 # ------------------------------------------------------------------------------
 spack:checkout:
-  stage: .pre
+  stage: checkout
   variables:
     APPTAINER_EXEC_OPTIONS: >-
       --cleanenv
@@ -257,3 +259,40 @@ post_cleaning:
     - ${environment}
   script:
     - ./ci/cleaning_fs.sh
+
+.code-quality: &code-climate
+  stage: linters
+  image:
+    name: registry.hpc.epfl.ch/scitas/linters-collection:latest
+    pull_policy: always
+  allow_failure: true
+  after_script:
+    - |
+      if [ ! -s gl-codequality.json ]; then
+        echo [] | tee gl-codequality.json | jq -C .;
+      fi
+  artifacts:
+    reports:
+      codequality: [gl-codequality.json]
+    paths:
+      - gl-codequality.json
+
+cq:hadolint:
+  <<: *code-climate
+  script:
+    - hadolint --format codeclimate dockerfiles/**/Dockerfile | tee gl-codequality.json | jq -C .
+
+cq:shellcheck:
+  <<: *code-climate
+  script:
+    - |
+      git ls-files . \
+        | xargs -r -n1 file \
+        | awk -F: '/shell script/{print $1}' \
+        | xargs -r -n1 shellcheck -f json \
+        | tee -a gl-codequality.json | jq -C .
+
+cq:yamllint:
+  <<: *code-climate
+  script:
+    - yamllint_codeclimate --standalone | tee gl-codequality.json | jq -C .

.hadolint.yaml

+---
+failure-threshold: "style"             # name of threshold level (error | warning | info | style | ignore | none)
+format: "codeclimate"                  # Output format (tty | json | checkstyle | codeclimate | gitlab_codeclimate | gnu | codacy)
+ignored: ["DL3041"]                    # list of rules
+no-color: false                        # true | false
+strict-labels: true                    # true | false
+trustedRegistries:
+  - "registry.hpc.epfl.ch"             # registry or list of registries
+  - "docker.io"

.yamllint.yml

+---
+extends: default
+
+rules:
+  line-length:
+    ignore:
+      - .hadolint.yaml
+      - .gitlab-ci.yml

stacks/pinot-noir-gcc/modules_empty.yaml

+modules:
+  default:
+    lmod: {}