Skip to content
Snippets Groups Projects

Add support for https and wss when using domain names

Closed Add support for https and wss when using domain names
slefort/webapp-lib:cpc/androz2091-wss-support into cpc/cleanup
All threads resolved!
Closed Simon Lefort requested to merge slefort/webapp-lib:cpc/androz2091-wss-support into cpc/cleanup
All threads resolved!

Detect when using https and automatically connects using wss. Also added support for port 80/443 when using a domain name.

Hello,

I have probably done things wrong and the point of this fork was to have a repository to share these changes with my teammates, but I would appreciate your feedback if you have some time to read this.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon Lefort added 1 commit

    added 1 commit

    • d75eb12a - Omit ws port when using default values

    Compare with previous version

  • Simon Lefort added 1 commit

    added 1 commit

    • 3cdcedea - Revert change of shareUrl and use /app endpoint

    Compare with previous version

  • Clément Pit-Claudel
    Clément Pit-Claudel @cpitclaudel
    Owner

    Thanks a lot for this! I'll rebase it an merge it once we have reviewed and tested the single-port change.

  • Clément Pit-Claudel resolved all threads

    resolved all threads

  • Clément Pit-Claudel
    Clément Pit-Claudel @cpitclaudel
    Owner

    Rebased and merged manually in 44b6426f . Thanks!

  • Clément Pit-Claudel closed

    closed

    • Please register or sign in to reply