Skip to content
Snippets Groups Projects

Propose to add bare README explaining how to contribute

Merged Federico Felici requested to merge feature/add_README into master

@amerle @osauter here is a merge request for a README file that explains how to contribute to the master branch. This is very 'meta'.

Merge request reports

Checking pipeline status.

Merged by Olivier SauterOlivier Sauter 5 years ago (Jul 12, 2019 1:14pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #6 (closed)

  • I see we are going the eco-friendly way ...

  • Olivier Sauter mentioned in commit edda7980

    mentioned in commit edda7980

  • I just click on merge (did not look at the file) so you can continue changing it ...

  • By clicking on 'merge' you merged it with the master branch. So it can not be changed any more unless by a new merge request. If we wanted to change the README file further, we could have changed it on this branch before completing the merge.

    In general it is good practice to look at what is being merged before accepting a merge request.

  • It is my personal opinion that protecting the master branch and having all changes go via a merge request is a good practice:

    • It helps to have more 'eyes' looking at the code, so more people know what is in the code.
    • Spot bugs early (when the change it made, not later when it is found that the change leads to a bug...)

    I know this requires a change of the way we usually work but I really think it's worth trying..

    Edited by Federico Felici
  • I think it's good to have a merge request and then somebody doing the merge. I would only require (if possible) that it is somebody else than the author that is doing the merge, so we have at least 2 persons overviewing it. But more than 2 can slow down quite a bit since we are not many... And we allow the author to merge if he has the rights, if it is urgent. Note that the tests should ensure minimum security, much better than before in any case...

    How many can do the merge? I guess I can see the rights for master somewhere...

  • I think it's good to have a merge request and then somebody doing the merge. I would only require (if possible) that it is somebody else than the author that is doing the merge, so we have at least 2 persons overviewing it. But more than 2 can slow down quite a bit since we are not many... And we allow the author to merge if he has the rights, if it is urgent. Note that the tests should ensure minimum security, much better than before in any case...

    How many can do the merge? I guess I can see the rights for master somewhere...

  • You can look at settings -> repository for the 'protected branches' and settings -> members to see who has which level of rights for this project.

Please register or sign in to reply
Loading